Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce some file system paths' lengths #15689

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jan 5, 2025

Removes ./test/cmdlineTests/standard_model_checker_show_unsupported_false_all_engines/standard_model_checker_show_unsupported_false_all_enginesstandard_model_checker_show_unsupported_false_bmc.

Fixes #15688.

Copy link

github-actions bot commented Jan 5, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DaniPopes thanks for finding this. This test was not even been run because it is indeed in the wrong subdirectory so our test suite couldn't find it. But after taking a look at the test, it does not make sense to have it, since this one here: https://github.com/ethereum/solidity/blob/develop/test/cmdlineTests/standard_model_checker_show_unsupported_false_all_engines/input.json already test the same thing.

Could you please just remove this test?

Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The failing CI tests are unrelated and we are taking a look at it :)

@nikola-matic nikola-matic enabled auto-merge January 9, 2025 10:08
@nikola-matic nikola-matic merged commit 35bd987 into ethereum:develop Jan 9, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very long file system paths
3 participants