Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapts to new Boost download location #15691

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

clonker
Copy link
Member

@clonker clonker commented Jan 6, 2025

Fixes #15690

PR switching to the new emscripten docker file: #15693

@clonker clonker force-pushed the boost_download_location branch from b07d539 to ac4d267 Compare January 6, 2025 10:36
@clonker clonker requested a review from r0qs January 6, 2025 10:47
Copy link

github-actions bot commented Jan 6, 2025

solbuildpackpusher/solidity-buildpack-deps:emscripten-20 [solbuildpackpusher/solidity-buildpack-deps@sha256:98f963ed799a0d206ef8e7b5475f847e0dea53b7fdea9618bbc6106a62730bd2].

Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a PR switching to the new docker file (and look at tests there to proceed with merging here)

We can keep ignoring the ossfuzz image for now, since IIRC it'll be separately fixed.

I'm not approving, since I don't see the sibling PR switching the image hashes for CI yet (if there is one, link it in the description)

Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approving this (even though it's technically not the correct sequence of changes), since the emscripten build in #15691 passed (we should wait for the tests with merging it, though).

Not sure if we should even touch the ossfuzz image here, but I guess better to avoid confusion about the URL here when finally fixing it properly, so fine with keeping the change here, even though we can't build the image.

@clonker clonker merged commit 9aff769 into develop Jan 6, 2025
77 of 78 checks passed
@clonker clonker deleted the boost_download_location branch January 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloaded Boost source package failed
2 participants