Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logical operator behavior documentation #15695

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

afrasiyabhaider
Copy link

  • Clarified the short-circuiting behavior of logical operators || and &&.
  • Explained that in expressions like f(x) || g(y), if f(x) evaluates to true, g(y) will not be executed, preserving performance and avoiding unintended side effects.

- Clarified the short-circuiting behavior of logical operators `||` and `&&`.
- Explained that in expressions like `f(x) || g(y)`, if `f(x)` evaluates to true, `g(y)` will not be executed, preserving performance and avoiding unintended side effects.
Copy link

github-actions bot commented Jan 8, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Collaborator

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original wording is perfectly succinct - your extension doesn't really add anything of value, and only makes it sound like an article/blogpost written about the short circuiting behaviour, rather than documentation.

The changes I can accept are the (second) backtick (`) additions, since the original does not conform to our double backtick style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants