Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTChecker: Fix error when initializing fixed-sized-bytes array #15701

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

blishko
Copy link
Contributor

@blishko blishko commented Jan 9, 2025

When encoding initialization of an array of fixed-sized bytes, we need to make sure the elements of the inlined array have the right SMT sort. Because of implict conversion from string literals to fixed-sized bytes, we need to pass the information about the desired type when encoding the individual elements.

Fixes #15603.

When encoding initialization of an array of fixed-sized bytes, we need
to make sure the elements of the inlined array have the right SMT sort.
Because of implict conversion from string literals to fixed-sized bytes,
we need to pass the information about the desired type when encoding the
individual elements.
@blishko blishko added smt 🟡 PR review label labels Jan 9, 2025
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we could leave the changelog indentation to be fixed during the release, but I'm fine either way.

@blishko
Copy link
Contributor Author

blishko commented Jan 9, 2025

Looking at the changelog, it seems the policy has always been to have a space before the star.
Not sure why now the Bugfixes section did not have it.
I think it would be good to be consistent with that.

@blishko blishko merged commit 6355ff6 into develop Jan 9, 2025
74 checks passed
@blishko blishko deleted the smt-fix-array-of-strings branch January 9, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smt 🟡 PR review label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMTChecker: SMT logic error caused by assigning values to a fixed-size array.
2 participants