Handle first row blanks, parse booleans correctly, "" in varchars should be NULL #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft until I get the tests added |
|
Closes #47 |
|
Also figured out how to just parse the return types once! Not sure what the CI failures were (it is re-running with this commit) |
|
Howdy Archie! I believe the CI failures are unrelated. The error messages seem to indicate something that is up with deployment and not building. |
Yes, let's do a release when this merges. Maybe will fix the issue with 0.0.3 |
archiewood
approved these changes
Dec 30, 2024
|
A bump seems to have fixed the tests |
|
or not, this is very strange as it worked before |
|
Okay great, will merge this and remove deploy in separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what you think!
Would you be open to doing a release to the community repo at some point in the next few weeks (post holidays is fine for sure!).