Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching-brackets: Explicitly check with true? in tests #700

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

matching-brackets: Explicitly check with true? in tests #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa8d403
update starter file
tasxatzial Nov 1, 2024
4e47176
explicitly check for `true` in tests
tasxatzial Nov 1, 2024
9fa5e5d
update config
tasxatzial Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exercises/practice/matching-brackets/.meta/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"AndreaCrotti",
"haus",
"sjwarner-bp",
"yurrriq"
"yurrriq",
"tasxatzial"
],
"files": {
"solution": [
Expand Down
7 changes: 4 additions & 3 deletions exercises/practice/matching-brackets/src/matching_brackets.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
(ns matching-brackets)

(defn valid? [] ;; <- arglist goes here
;; your code goes here
)
(defn valid?
[s]
;; function body
)
58 changes: 29 additions & 29 deletions exercises/practice/matching-brackets/test/matching_brackets_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,82 +2,82 @@
(:require [clojure.test :refer [deftest testing is]]
matching-brackets))

(deftest paired-square-brackets
(testing "paired square brackets"
(is (matching-brackets/valid? "[]"))))
(deftest test-81ec11da-38dd-442a-bcf9-3de7754609a5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the use of the GUID here. Why the change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no one seems to be sharing their opinions on the Clojure thread in the forum, I’ll create a new thread about function naming to gather input from other maintainers. I'd like to have a clearer understanding before reconsidering.

(testing "Paired square brackets"
(is (true? (matching-brackets/valid? "[]")))))

(deftest empty-string
(deftest test-287f0167-ac60-4b64-8452-a0aa8f4e5238
(testing "Empty string"
(is (matching-brackets/valid? ""))))
(is (true? (matching-brackets/valid? "")))))

(deftest unpaired-brackets
(deftest test-6c3615a3-df01-4130-a731-8ef5f5d78dac
(testing "Unpaired brackets"
(is (false? (matching-brackets/valid? "[[")))))

(deftest wrong-ordered-brackets
(deftest test-9d414171-9b98-4cac-a4e5-941039a97a77
(testing "Wrong ordered brackets"
(is (false? (matching-brackets/valid? "}{")))))

(deftest wrong-closing-bracket
(deftest test-f0f97c94-a149-4736-bc61-f2c5148ffb85
(testing "Wrong closing bracket"
(is (false? (matching-brackets/valid? "{]")))))

(deftest paired-with-whitespace
(deftest test-754468e0-4696-4582-a30e-534d47d69756
(testing "Paired with whitespace"
(is (matching-brackets/valid? "{ }"))))
(is (true? (matching-brackets/valid? "{ }")))))

(deftest partially-paired-brackets
(deftest test-ba84f6ee-8164-434a-9c3e-b02c7f8e8545
(testing "Partially paired brackets"
(is (false? (matching-brackets/valid? "{[])")))))

(deftest simple-nested-brackets
(deftest test-3c86c897-5ff3-4a2b-ad9b-47ac3a30651d
(testing "Simple nested brackets"
(is (matching-brackets/valid? "{[]}"))))
(is (true? (matching-brackets/valid? "{[]}")))))

(deftest several-paired-brackets
(deftest test-2d137f2c-a19e-4993-9830-83967a2d4726
(testing "Several paired brackets"
(is (matching-brackets/valid? "{}[]"))))
(is (true? (matching-brackets/valid? "{}[]")))))

(deftest paired-and-nested-brackets
(deftest test-2e1f7b56-c137-4c92-9781-958638885a44
(testing "Paired and nested brackets"
(is (matching-brackets/valid? "([{}({}[])])"))))
(is (true? (matching-brackets/valid? "([{}({}[])])")))))

(deftest unopened-closing-brackets
(deftest test-84f6233b-e0f7-4077-8966-8085d295c19b
(testing "Unopened closing brackets"
(is (false? (matching-brackets/valid? "{[)][]}")))))

(deftest unpaired-and-nested-brackets
(deftest test-9b18c67d-7595-4982-b2c5-4cb949745d49
(testing "Unpaired and nested brackets"
(is (false? (matching-brackets/valid? "([{])")))))

(deftest paired-and-wrong-nested-brackets
(deftest test-a0205e34-c2ac-49e6-a88a-899508d7d68e
(testing "Paired and wrong nested brackets"
(is (false? (matching-brackets/valid? "[({]})")))))

(deftest paired-and-wrong-nested-brackets-but-innermost-are-correct
(deftest test-1d5c093f-fc84-41fb-8c2a-e052f9581602
(testing "Paired and wrong nested brackets but innermost are correct"
(is (false? (matching-brackets/valid? "[({}])")))))

(deftest paired-and-incomplete-brackets
(deftest test-ef47c21b-bcfd-4998-844c-7ad5daad90a8
(testing "Paired and incomplete brackets"
(is (false? (matching-brackets/valid? "{}[")))))

(deftest too-many-closing-brackets
(deftest test-a4675a40-a8be-4fc2-bc47-2a282ce6edbe
(testing "Too many closing brackets"
(is (false? (matching-brackets/valid? "[]]")))))

(deftest early-unexpected-brackets
(deftest test-a345a753-d889-4b7e-99ae-34ac85910d1a
(testing "Early unexpected brackets"
(is (false? (matching-brackets/valid? ")()")))))

(deftest early-mismatched-brackets
(deftest test-21f81d61-1608-465a-b850-baa44c5def83
(testing "Early mismatched brackets"
(is (false? (matching-brackets/valid? "{)()")))))

(deftest math-expression
(deftest test-99255f93-261b-4435-a352-02bdecc9bdf2
(testing "Math expression"
(is (matching-brackets/valid? "(((185 + 223.85) * 15) - 543)/2"))))
(is (true? (matching-brackets/valid? "(((185 + 223.85) * 15) - 543)/2")))))

(deftest complex-latex-expression
(deftest test-8e357d79-f302-469a-8515-2561877256a1
(testing "Complex latex expression"
(is (matching-brackets/valid? "\\\\left(\\\\begin{array}{cc} \\\\frac{1}{3} & x\\\\\\\\ \\\\mathrm{e}^{x} &... x^2 \\\\end{array}\\\\right)"))))
(is (true? (matching-brackets/valid? "\\\\left(\\\\begin{array}{cc} \\\\frac{1}{3} & x\\\\\\\\ \\\\mathrm{e}^{x} &... x^2 \\\\end{array}\\\\right)")))))
Loading