Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word-count - update tests specification to version 1.4.0 #299

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

marko213
Copy link
Contributor

Adds three test cases:

* substrings_from_the_beginning (exercism/problem-specifications#1557)
* multiple_spaces_not_detected_as_a_word (exercism/problem-specifications#1023)
* alternating_word_separators_not_detected_as_a_word (exercism/problem-specifications#1446)
@arcuru
Copy link
Contributor

arcuru commented Aug 3, 2019

So, it looks like the other tests are rather out of date as well...Can you update all of the tests to match the latest problem specifications and then add a note at the top with the new version?

This is fine, I just prefer to fully update to the latest test suite version when we do these :)

Example:

// Collatz-conjecture exercise test case data version 1.2.1

@marko213
Copy link
Contributor Author

marko213 commented Aug 3, 2019

Ok, I'll close this PR, then create another one once I've worked through all the exercises.

@marko213 marko213 closed this Aug 3, 2019
@arcuru
Copy link
Contributor

arcuru commented Aug 3, 2019

Wait, I just meant the tests for word-count that are in this same file, not for all the exercises. I meant only updating the word-count tests to v1.4.0.

If you just mean you don't have time to do that, I will still take these changes.

@arcuru arcuru reopened this Aug 3, 2019
@marko213
Copy link
Contributor Author

marko213 commented Aug 3, 2019

Ok, I'll do that.

Is there a need for all the exercises to be updated, as I misunderstood? I think I could give that a try too.

@arcuru
Copy link
Contributor

arcuru commented Aug 5, 2019

For this change, this is exactly what I was looking for, thanks!

Right now most of the test suites are out of date to the latest on problem-specifications, but there isn't really a good way to tell how out of date they are unless we go through all the individual tests. We've started adding the note about what test version it matches to the top of the test file so that there's an easier way to check that quickly.

Whenever a test suite is modified or created I have been pushing for the test suite to always do the full update to the latest version and add the version line. I haven't really pushed for an effort to update all of them, I've just been making sure that whenever we do have an update that it gets updated fully.

exercism/exercism#4390
If the tool mentioned in this linked thread is ever built, this will be a lot easier to keep fully up to date. I've been holding off on pushing for a full update of the test suites since there's no way to keep them in sync yet.

(I should add this to the README I think, but I don't have the time this second)

@arcuru arcuru merged commit 5ba9629 into exercism:master Aug 5, 2019
@marko213 marko213 deleted the word-count-patch branch August 5, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants