-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pubspec: Upgrade sdk constraints to Dart 3.2 as minimum #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks for this.
Perhaps this too: dart/.github/workflows/test.yml Line 23 in 42b0826
|
@vaeng, shall we coordinate this PR with a similar upgrade in exercism/dart-test-runner |
I don't know anything about dart compatibility, but I think my changes to the test runner would adapt easily to a new version. I'll do a pr today |
Here is the PR to update the test runner to dart 3.2 |
@Stargator I see this
final expectedList = retrieveListOfExpected(specCases);
final dynamic first = expectedList != null && expectedList.isNotEmpty ? expectedList.first : null;
|
Yeah, I just made the pubspec changes on Friday and couldn't see the results of the checks until now. All should be resolved there. |
I did not change anything from the old 2.18 (?) Student files in the test runner, so this subset is still valid. I really never looked at any docs for dart except the test environment (which was not helpful for me). So if anything big has changed between the two versions, I'm the last to notice :D |
@vaeng I think you replying to my question in the dart-test-runner, but the link to the changes is here. As with any major version change, there are breaking changes. But so far, nothing broke in this PR when running the tests for the exercises, but that does not rule out students using other APIs that may have been deprecated or removed. |
Upgrade our minimum SDK constraint to 3.2 (the latest version of Dart)