Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule for practice exercise custom-set #61

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add rule for practice exercise custom-set #61

merged 2 commits into from
Oct 30, 2023

Conversation

jiegillet
Copy link
Contributor

@jiegillet jiegillet commented Oct 28, 2023 •
edited
Loading

Closes #49.
Sister PR here.
Pretty straightforward one using Analyzer.functionCalls :)

@jiegillet jiegillet requested a review from a team as a code owner October 28, 2023 05:59
@jiegillet jiegillet mentioned this pull request Oct 28, 2023
Merged
ceddlyburge
ceddlyburge approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@ceddlyburge ceddlyburge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and pleasingly simple :)

@jiegillet
Copy link
Contributor Author

@exercism/maintainers-admin can I have an approval please? 💛

@jiegillet jiegillet merged commit 07fa26f into main Oct 30, 2023
6 checks passed
@jiegillet jiegillet deleted the jie-custom-set branch October 30, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceddlyburge ceddlyburge ceddlyburge approved these changes

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write analysis for practice exercise custom-set
3 participants
@jiegillet @ErikSchierboom @ceddlyburge