Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common rule for all exercises: no Debug functions #68

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Conversation

jiegillet
Copy link
Contributor

@jiegillet jiegillet commented Nov 3, 2023

Sister PR here.
Part of #13.

This check is meant to be a rule checked against all solutions, and warns students against publishing solution with Debug functions in them.

There are two more common rules that I feel are appropriate after this one:

  • Disallow -- TODO comments (some stubs have this, sometimes students don't remove them, but it's just noise)
  • Comment on variable names not in camelCase, since it's such a strong standard in Elm

Anything else from the list on the issue is not as clear to me and would need discussion.

@jiegillet jiegillet merged commit 2505db9 into main Nov 5, 2023
5 of 6 checks passed
@jiegillet jiegillet deleted the jie-debug branch November 5, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants