REST-API: Update expected user balance of last test #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User balance of test "lender owes borrower same as new loan" is not formatted as the previous cases. For example "lender has negative balance" has an expected user balance of zero formatted as "0.0" as all other values while the last test has zero formatted as "0".
rpottsoh
changed the title
rpottsoh
requested changes
Jan 14, 2019
| } |
There was a problem hiding this comment.
A small nit pick, but this change is not related to the other change you made earlier in the file.
There was a problem hiding this comment.
I've created an issue for this, as it is a common issue with PR's created using the GitHub interface: #1443
|
Oh, @davidelettieri you should look into and see what the issue is that Travis CI is having. |
ErikSchierboom
approved these changes
Jan 14, 2019
| } |
There was a problem hiding this comment.
I've created an issue for this, as it is a common issue with PR's created using the GitHub interface: #1443
The issue is that the version number should be incremented. |
|
Looking great! |
rpottsoh
approved these changes
Jan 15, 2019
cmccandless
approved these changes
Jan 15, 2019
|
Merged! Thanks a lot @davidelettieri! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User balance of test "lender owes borrower same as new loan" is not formatted as the previous cases. For example "lender has negative balance" has an expected user balance of zero formatted as "0.0" as all other values while the last test has zero formatted as "0".