-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add titles to the metadata for all exercises #2122
Conversation
Only a handful of exercises had titles. These were typically exercises where the correct title would be difficult to guess based on the slug (e.g. D&D Characters). However, it turns out that many exercises have variations on the titles across different tracks. This hard-codes titles for all the exercises, even if they would technically be fairly straight forward to derive from the slug. This will allow us to have configlet normalize titles.
84f4208
to
471ceae
Compare
I like the idea to ensure that the For example, we'd change the title of DnD Character in:
to match the title of D&D Character in all the other implementations:
But what was the intention for configlet? The options I see immediately are:
|
I will submit PRs to all tracks this week to make them match the title in problem specifications. Once we know that all tracks are in compliance, I think it would make sense to do 1 & 3. |
Currently, the What should we do with the new a. Add the Without thinking about it much, my preference is option a so that |
From a tool-maintainer perspective I would also instinctively want to do (a), but from a product point of view I would prefer (c), as the track I think I would prefer for From the perspective of someone using configlet to help bootstrap a track, I think the most helpful thing would be to have a separate
I'm not sure what the ideal behavior would be around the tests. Probably you'd want to either ask for confirmation for each test, but maybe just defer the problem and have people sync the tests separately. This would remove a lot of the fiddly bits of getting started with a new exercise, even if the track doesn't have a generator, and then we could assume that the |
OK.
I've also thought about this. Could you please open an issue in the configlet repo? We'd want it to work for both concept exercises and practice exercises, right? Then I think we'd want a
And filepaths, right?
Ideally, I think Edit:
Mmm. First reaction: I think we shouldn't do this, because we don't want a |
Yes, I'll do this now.
Yes, and filepaths.
Hm, yes, on reading this my conclusion is that you're right. So the conclusion so far is:
|
Only a handful of exercises had titles.
These were typically exercises where the correct title would be difficult to guess based on the slug (e.g. D&D Characters).
However, it turns out that many exercises have variations on the titles across different tracks.
This hard-codes titles for all the exercises, even if they would technically be fairly straight forward to derive from the slug.
This will make it easier for Configlet to do normalization on the track
config.json
.