Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bracket-push exercise to matching-brackets #402

Merged
merged 11 commits into from
Aug 29, 2021

Conversation

thomchop
Copy link
Contributor

@thomchop thomchop commented Nov 6, 2020

Resolves #379

This rename was proposed in: exercism/problem-specifications#1501

The rationale for the name is:

  • to name the exercise by its story, not by what it potentially teaches
  • to avoid unnecessarily biasing the solution space

@iHiD
Copy link
Member

iHiD commented Nov 6, 2020

Thanks a lot for this!

Once this is approved, can we leave @ErikSchierboom to merge it please, so we can check it all goes through properly on the website end. Renaming exercises can be slightly problematic, and I believe I've fixed everything, but it would be good to hand-hold it over the line :)

Base automatically changed from master to main January 28, 2021 19:16
@@ -1,7 +1,8 @@
# Bracket Push
# Matching Brackets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change in requirements for practice exercises, and this file now needs to be in .docs/instructions.md instead of README.md (docs: https://github.com/exercism/docs/blob/main/building/tracks/practice-exercises.md#file-docsinstructionsmd)

@iHiD iHiD merged commit 5ab65dd into exercism:main Aug 29, 2021
@iHiD
Copy link
Member

iHiD commented Aug 29, 2021

@ErikSchierboom Could you double check this one for me pls.


@thomchop Thanks for doing this. Sorry it took so long to get sorted.
@angelikatyborska Thanks for the nudge to me about what needed sorting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bracket-push: renamed to matching-brackets
3 participants