Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two-fer tests.toml #245

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Add two-fer tests.toml #245

merged 1 commit into from
Dec 28, 2023

Conversation

BNAndras
Copy link
Member

Should be merged as [no important files changed] since all three tests are accounted for.

@BNAndras BNAndras added the x:rep/tiny Tiny amount of reputation label Dec 27, 2023
@BNAndras BNAndras requested a review from kotp December 27, 2023 16:20
@BNAndras BNAndras linked an issue Dec 27, 2023 that may be closed by this pull request
Several tests need to be synced #248
Open
11 tasks
kotp
kotp approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not positive, but I believe that [no important files changed] directive has to be in the commit itself.

@BNAndras
Copy link
Member Author

Yeah, it should be in the body of the commit that merges in the PR.

@BNAndras BNAndras merged commit ffc0664 into exercism:main Dec 28, 2023
4 checks passed
@BNAndras BNAndras deleted the add-twofer-toml branch December 28, 2023 07:32
@BNAndras BNAndras removed a link to an issue Dec 28, 2023
Several tests need to be synced #248
Open
11 tasks
@BNAndras
Copy link
Member Author

Related to #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp approved these changes

Assignees
No one assigned
Labels
x:rep/tiny Tiny amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BNAndras @kotp