Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elm maze-maker analyzer comments #2281

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add Elm maze-maker analyzer comments #2281

merged 1 commit into from
Oct 24, 2023

Conversation

jiegillet
Copy link
Contributor

@jiegillet jiegillet commented Oct 23, 2023 •
edited
Loading

Sister PR over here.

@ceddlyburge would you check these?

@jiegillet jiegillet mentioned this pull request Oct 23, 2023
Merged
@github-actions github-actions bot added track/elm Elm track type/analyzer-comments Analyzer comments labels Oct 23, 2023
ceddlyburge
ceddlyburge approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ceddlyburge ceddlyburge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all match up with the identifiers in the ruleConfig of the sister PR, and the text matches the identifiers sensibly.

@jiegillet jiegillet requested a review from a team October 24, 2023 09:08
@jiegillet
Copy link
Contributor Author

Thank you! We also have a CI check on the test-runner to make sure the paths match. It fails when it's not merged yet though :)
@exercism/reviewers can I get an approval please? 💛

BethanyG
BethanyG approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 😄

@jiegillet jiegillet merged commit 3ed9b72 into main Oct 24, 2023
1 check passed
@jiegillet jiegillet deleted the jie-maze-maker branch October 24, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceddlyburge ceddlyburge ceddlyburge approved these changes

@BethanyG BethanyG BethanyG approved these changes

Assignees
No one assigned
Labels
track/elm Elm track type/analyzer-comments Analyzer comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiegillet @BethanyG @ceddlyburge