[steps] [ENG-14503] base64 encode envs in custom builds #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using set-env command base64-encode the value of the env var before saving to a file See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
When collecting envs base64-decode them See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
Removed the env utils which are no longer used See: https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-14503/base64-encode-env-vars-in-custom-builds
How
Encoding envs when using
set-envDecoding when collecting for updating the context
Test Plan
Automated tests pass
Tested manually