Remove node-fetch #116
Open
Remove node-fetch #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katayama8000
requested review from
douglowder
and removed request for
a team
katayama8000
force-pushed
the
remove_node-fetch
branch
from
0233b76 to
e14fa1a
Compare
|
@douglowder Could you review it? |
|
I've fixed our test workflow to run on pull requests, so if you update your branch, all those required statuses will pass: 
Sorry that we didn't have that set up already, thanks again for the contribution! |
katayama8000
force-pushed
the
remove_node-fetch
branch
from
d2d8422 to
5bbecf4
Compare
douglowder
reviewed
Dec 30, 2024
douglowder
requested changes
Dec 30, 2024
| fetchOptions.dispatcher = this.httpAgent; | ||
| } | ||
|
|
||
| const response = await fetch(url, fetchOptions); |
There was a problem hiding this comment.
Seeing a TS type check failure here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.