Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron] Add settings option to context menu #233

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Dec 18, 2024

Why

On macOS if there is any problem with the react-native UI in the menu-bar, users can right click the menu icon and open the settings screen, we have the same option on Windows and Linux

How

Add settings option to context menu

Test Plan

Run menu bar locally on Windows

@gabrieldonadel gabrieldonadel marked this pull request as ready for review December 19, 2024 14:09
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-right-click branch from c03bf5f to 95d00f3 Compare December 19, 2024 14:11
@gabrieldonadel gabrieldonadel merged commit 16dcaaf into main Dec 19, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/electron-right-click branch December 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants