Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Force Ubuntu 22.04 for input and query API workflows #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −11
Open

build: Force Ubuntu 22.04 for input and query API workflows #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pnp-api-prod-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ on:
jobs:
prod:
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pnp-input-api-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ on:

jobs:
test-opa-policies:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Contributor

@TurcanStanislav TurcanStanislav Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem that we use setup-nuget github action nor depend on nuget here. Is there another reason to change it here? The same question for other places.

Copy link
Contributor Author

@nadiiaboichuk nadiiaboichuk Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense to use the same OS everywhere instead of using one OS for one job and another one for other jobs

steps:
- uses: actions/checkout@v4
with:
Expand All @@ -110,7 +110,7 @@ jobs:
service-account-key: ${{ secrets.SECRET_AUTH }}

test-application:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:

staging:
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: test-application
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -307,7 +307,7 @@ jobs:

acceptance:
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: staging
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -410,7 +410,7 @@ jobs:

release:
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: acceptance
steps:
- uses: actions/checkout@v4
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pnp-query-api-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ on:

jobs:
test-opa-policies:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -89,7 +89,7 @@ jobs:
service-account-key: ${{ secrets.SECRET_AUTH }}

test-application:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
staging:
needs: test-application
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:
acceptance:
needs: staging
if: ${{ github.ref == 'refs/heads/master' && inputs.has-k6-tests == true }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
k6-test-file-name: ${{ fromJSON(inputs.k6-tests-file-names) }}
Expand Down Expand Up @@ -298,7 +298,7 @@ jobs:
github.ref == 'refs/heads/master' &&
needs.staging.result == 'success' &&
(inputs.has-k6-tests == false || needs.acceptance.result == 'success')
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
Expand Down
Loading