Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8]통합테스트 및 DB연결 #9

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[#8]통합테스트 및 DB연결 #9

wants to merge 9 commits into from
+1,015 −971

Conversation

seunghaen
Copy link
Collaborator

@seunghaen seunghaen commented Jan 6, 2025 •
edited
Loading

  1. 서비스 레이어의 추가를 통해 수정이 필요한 통합테스트 코드를 보완
  2. 실제DB 연결작업
  • 도커를 이용하여 MySql을 연결

@seunghaen seunghaen requested a review from f-lab-lyan January 7, 2025 13:24
@seunghaen
JPA 엔터티 설정 및 관련 레포와 테스트 수정
8d9e761 
- 테이블 생성 에러 발생으로 엔터티 생성과 관련 통합테스트 수정필요
@seunghaen
.env 제거
67a80a4
@seunghaen seunghaen changed the base branch from main to feature/create-service2 January 7, 2025 14:08
f-lab-lyan
f-lab-lyan reviewed Jan 7, 2025
View reviewed changes
application/src/main/java/com/terte/repository/menu/MenuRepository.java Outdated

public interface MenuRepository extends JpaRepository<Menu, Long> {
Optional<List<Menu>> findByStoreId(Long storeId);
Copy link

@f-lab-lyan f-lab-lyan Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional<List<Menu>>가 List<Menu>가 emptyList인 경우에는?

Base automatically changed from feature/create-service2 to main January 11, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-lyan f-lab-lyan f-lab-lyan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seunghaen @f-lab-lyan