Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SCRUM-71 홈, 캘린더, 검색, 설정 바텀 네비게이션 구현 #2

Closed
wants to merge 2 commits into from

Conversation

towitty
Copy link
Collaborator

@towitty towitty commented Sep 14, 2024

What is this PR? 💬

  • 홈, 캘린더, 검색, 설정 바텀 네비게이션 구현했습니다.
  • 다른 github repository 코드를 참고하여 Fragment 와 Activity 의 binding backing property 기존 non-null assertion 이던 부분을 requireNotNull(_binding) 로 변경하였습니다.
  • binding 프로퍼티를 onDestroy() 에서 null로 초기화 해줍니다. super.onDestroy() 를 null 초기화 이후 호출하여 정상적으로 Destory() 되지 못했을 때의 안정성을 높였습니다.
private var _binding: FragmentSearchBinding? = null
private val binding get() = requireNotNull(_binding)
private val searchViewModel:SearchViewModel by viewModels()
override fun onDestroyView() {
    _binding = null
    super.onDestroyView()
}

Changes 👀

  • [feature] 네비게이션 기능 구현
  • [modify] binding backing property 수정
  • [add/resource] 홈, 캘린더, 검색, 설정 vector icon 추가

Screenshot 📷

Screen_recording_BookReport_._.mp4

Question 🤔

  • commit 을 어떻게 작게 쪼개면 좋을지 모르겠습니다. 지금 commit 이 굉장히 무거운 것 같은데, 멘토님 생각은 어떠신가요 ?
  • binding 프로퍼티를 사용할 때 lateinit, non-null assertion, requireNotNull 세가지 서로 차이가 거의 없는 것 같다는 생각이 드는데 오버엔지니어링 일까요 ?

@towitty towitty closed this Sep 16, 2024
@towitty towitty deleted the SCRUM-69 branch September 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant