[#14] 팀 목록 조회 API 구현 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-jason
reviewed
Apr 1, 2024
| private final TeamMapper teamMapper; | ||
|
|
||
| public List<Team> getTeams() { | ||
| return teamMapper.selectTeams(); |
There was a problem hiding this comment.
팀의 목록이 사실상 그렇게 많지 않아서일거라고 생각되는데..페이징은 딱히 필요없나요?
There was a problem hiding this comment.
해당 월의 경기로 최대 30일만 가져와서 필요없다고 생각했습니다..! 후에 기능구현 후 추가하도록 하겠습니당!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련이슈
작업내용
controller,service성공 유닛 테스트 추가참고사항
궁금한점