Fixed Typos in intro.md and CONTRIBUTING.md #1735
Conversation
CONTRIBUTING.md
Outdated
| @@ -68,7 +68,7 @@ with your real name (first and last name) | |||
| If you set your `user.name` and `user.email` git configs, you can sign your | |||
| commit automatically with `git commit -s`. If you forgot this you can | |||
| use `git commit -s --amend` to add this in retrospective for the last commit. | |||
| If you need to sign-off multiple commits within a branch, you need to do an interactive | |||
| If you need to sign off multiple commits within a branch, you need to do an interactive | |||
There was a problem hiding this comment.
Please keep sign-off . It implies user to use git commit --sign-off
There was a problem hiding this comment.
I changed that @rohanKanojia
CONTRIBUTING.md
Outdated
| @@ -34,22 +34,22 @@ license document, but changing it is not allowed. | |||
|
|
|||
| Developer's Certificate of Origin 1.1 | |||
|
|
|||
| By making a contribution to this project, I certify that: | |||
| By contributing to this project, I certify that: | |||
There was a problem hiding this comment.
I think this is directly taken from https://developercertificate.org/
I would not modify text in this code block. It should exactly match it's source.
There was a problem hiding this comment.
@rohanKanojia , I've just changed that phrase to https://developercertificate.org/
|
@mdxabu Could you please squash your commits into one? |
@rohanKanojia , I Squashed those commits into one commit. |
|
@mdxabu : Thanks, could you please address #1735 (comment) as well? |
Ok |
CONTRIBUTING.md
Outdated
| permitted to submit under a different license), as indicated | ||
| in the file; or | ||
|
|
||
| (c) The contribution was provided directly to me by some other | ||
| person who certified (a), (b) or (c) and I have not modified | ||
| the person who certified (a), (b) or (c) and I have not modified |
There was a problem hiding this comment.
This needs to be corrected. And please, as @rohanKanojia mentioned, don't touch the Developer's Certificate of Origin part as we do not own this; we just replicate it here. If you want to update this, please get in touch with the Linux Foundation, when they change it, we will take it over here. Consider it like a law text, you can't change it even with errors.
There was a problem hiding this comment.
This needs to be corrected. And please, as @rohanKanojia mentioned, don't touch the Developer's Certificate of Origin part as we do not own this; we just replicate it here. If you want to update this, please get in touch with the Linux Foundation, when they change it, we will take it over here. Consider it like a law text, you can't change it even with errors.
I deleted that commit that I changed that Developer's Certificate. Now I just made changes only in into.md and CONTRIBUTING.md
|
@mdxabu thanks for the PR! Looks good to me, but please leave the part untouched that we copy over from somewhere. See my inline comment. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
============================================
+ Coverage 65.23% 65.31% +0.08%
- Complexity 2274 2280 +6
============================================
Files 172 172
Lines 10173 10184 +11
Branches 1403 1406 +3
============================================
+ Hits 6636 6652 +16
+ Misses 2984 2983 -1
+ Partials 553 549 -4 |
I Changed that please go through it, if you have any questions please ping me here, Does this repo have any discussion channel? |
|
|
Thanks, looks good now! But it looks also like you closed the PR or deleted the original repository. wrt/ Discussions: Sorry, we don't have yet but that is probably a good idea to enable GitHub discussions. Wdyt, @rohanKanojia ? |
Dear Maintainer,
I wanted to inform you that I have made some typos and grammar corrections in the
CONTRIBUTING.mdandintro.mdfile. I have opened a PR for the changes to be reviewed and merged.Best regards,
F Mohamed Abdullah