Issue #1763 & #1676 #1764
Merged
Issue #1763 & #1676 #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattias Andersson <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1764 +/- ##
=========================================
Coverage 65.75% 65.75%
Complexity 2295 2295
=========================================
Files 172 172
Lines 10181 10181
Branches 1405 1405
=========================================
Hits 6695 6695
Misses 2934 2934
Partials 552 552
|
|
|
This change was originally done in #241 . Looking at the pull request I'm not able to understand what was the motivation for using the first 12 characters from image ID. |
rohanKanojia
approved these changes
Mar 9, 2024
|
@attiand : Thanks a lot! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand the reason to limit the image id. This works on Podman and Docker.