-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respects network configuration for buildx #1850
Conversation
this fix would help us greatly! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1850 +/- ##
============================================
+ Coverage 66.23% 66.27% +0.04%
- Complexity 2346 2351 +5
============================================
Files 174 174
Lines 10344 10354 +10
Branches 1434 1438 +4
============================================
+ Hits 6851 6862 +11
+ Misses 2930 2928 -2
- Partials 563 564 +1
|
Hello, is there anything more that I can/should do in this PR? |
Quality Gate passedIssues Measures |
@michaelmejaeger : Could you please add small mention of these properties in documentation? |
ah, I see it's a fix, not a feature. Please ignore my previous comment. |
@michaelmejaeger : Thanks a lot! |
Description
I have found that the configuration of the network (in Docker with the parameter
--network
) is not respected in multi-arch builds usingbuildx
. One can configure the network as stated in the documentation, however, this has no effect on the commandline call ofdocker
.Cause
The reason is that the configuration of
network
is simply not considered.Solution
I provided a unit tests which shows the problem and a fix that considers the configuration done via System properties, Maven properties, and in the configuration of the plugin.