Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[playground] Bug fix: prevent growing whitespaces in markdown table toggle #7041

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

potatowagon
Copy link
Contributor

Before

Screen.Recording.2025-01-11.at.6.58.29.PM.mov

^ white spaces in table cell growing

After

Screen.Recording.2025-01-11.at.7.03.38.PM.mov

^ num of white spaces remain constant

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 1:37am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 1:37am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2025
Copy link

github-actions bot commented Jan 11, 2025

size-limit report 📦

Path Size
lexical - cjs 29.07 KB (0%)
lexical - esm 28.89 KB (0%)
@lexical/rich-text - cjs 38.04 KB (0%)
@lexical/rich-text - esm 30.98 KB (0%)
@lexical/plain-text - cjs 36.57 KB (0%)
@lexical/plain-text - esm 28.26 KB (0%)
@lexical/react - cjs 39.84 KB (0%)
@lexical/react - esm 32.34 KB (0%)

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why this works but I think the actual bug is that on import mapToTableCells doesn't discard the required space before and after the | delimiter

@potatowagon potatowagon added this pull request to the merge queue Jan 12, 2025
@potatowagon potatowagon removed this pull request from the merge queue due to a manual request Jan 12, 2025
@potatowagon
Copy link
Contributor Author

I can see why this works but I think the actual bug is that on import mapToTableCells doesn't discard the required space before and after the | delimiter

good idea, ill explore that in another PR since this is approved already (needs a re-approval on ammendment)

@potatowagon potatowagon added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 63958a2 Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants