[lexical-table] Support table alignment #7044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
|
Rewrote this with classNames vs using 'style', to leave the option for overridability to users, but unsure if ended up any better because I couldn't get the class waterfall to work nicely without !imporant to override the margins. In both cases (style vs classNames) it works correctly with both with and without tableWrapper |
etrepum
reviewed
Jan 13, 2025
packages/lexical-playground/src/themes/PlaygroundEditorTheme.css
Outdated
Show resolved
Hide resolved
|
Thanks @etrepum, implemented the PR comments |
etrepum
reviewed
Jan 14, 2025
Addressed |
|
@etrepum could we wrap this one up please. |
etrepum
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6909
To differentiate between table alignment and cell text alignment, the table-level alignment logic only kicks in when the selection is the whole exact table. This does introduce the extra step if one wants to align all cell texts to do it in 2 steps, all columns except one and then the last column.
Before:
Screen.Recording.2025-01-12.at.19.57.08.mov
After:
Screen.Recording.2025-01-12.at.19.57.43.mov