This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #152 from sbalabanov/master
Make project fully compatible to FB opensource standards
- Loading branch information
Showing
8 changed files
with
106 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Code of Conduct | ||
|
||
Facebook has adopted a Code of Conduct that we expect project participants to adhere to. | ||
Please read the [full text](https://code.fb.com/codeofconduct/) | ||
so that you can understand what actions will and will not be tolerated. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Contributing to Nailgun | ||
|
||
We encourage the reporting of issues and bugs, along with pull requests to help make Nailgun codebase better. The following are some information and guidelines to help you contribute to Nailgun. | ||
|
||
## Tour of the Codebase | ||
|
||
This is a high-level overview of how the Nailgun repository is organized. | ||
|
||
### `nailgun-server/` | ||
|
||
That is where server side code lives, written in Java. It contains both core code under `src/main` and test code under `src/tests`. | ||
|
||
### `nailgun-client/` | ||
|
||
Client part of Nailgun, both C and Python versions in appropriate folders. | ||
|
||
### `nailgun-examples/` | ||
|
||
Some simple implementations of a Nail, helpful to understand how to write server-side code. One can also execute one of those nails for debugging or integration testing. | ||
|
||
### `scripts/` | ||
|
||
Automation scripts, mostly for continuous integration (i.e. Travis CI). | ||
|
||
### `tools/` | ||
|
||
Third-party dependencies used in tooling, like linter or code formatter. | ||
|
||
## Development Workflow | ||
|
||
### Building Nailgun | ||
|
||
As simple as running `mvn clean package`. | ||
|
||
### Running Tests | ||
|
||
Unit tests and integration tests are JUnit and they are run by Maven when you say 'mvn package'. To run E2E test, just execute `./scripts/travis_ci.sh`. It will also run `mvn package` first with all unit tests. | ||
|
||
### Using the IntelliJ IDE | ||
|
||
Just open project from Nailgun's root folder | ||
|
||
### Code Style | ||
|
||
Code is autoformatted with Maven plugin and Google code style is used. Be ready to have some changed files after building the project with Maven, so you may have to amend the change to git. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
# Copyright 2004-2015, Martian Software, Inc. | ||
# Copyright 2017-Present Facebook, Inc. | ||
|
||
from ng import NailgunConnection, NailgunException |
1 change: 1 addition & 0 deletions
1
nailgun-examples/src/main/java/com/facebook/nailgun/examples/Heartbeat.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
nailgun-server/src/main/java/com/facebook/nailgun/NGExitException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
nailgun-server/src/main/java/com/facebook/nailgun/builtins/NGVersion.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
nailgun-server/src/main/resources/com/facebook/nailgun/builtins/builtins.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters