Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI compiler matrix #634

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Update CI compiler matrix #634

merged 1 commit into from
Sep 11, 2024

Conversation

ispeters
Copy link
Contributor

@ispeters ispeters commented Sep 2, 2024

Update the compiler matrix:

  • add Clang 18
  • add MSVC 2022
  • remove MSVC 2019 C++17 since it's been broken forever
  • remove the configuration settings that ignore experimental failures

Also update spawn_future.hpp to keep the tests passing with MSVC 2022.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2024
@ispeters ispeters marked this pull request as ready for review September 2, 2024 00:43
Update the compiler matrix:
 - add Clang 18
 - add MSVC 2022
 - remove MSVC 2019 C++17 since it's been broken forever
 - remove the configuration settings that ignore experimental failures

Also update `spawn_future.hpp` to keep the tests passing with MSVC 2022.
@ispeters ispeters force-pushed the add_gcc_15_and_clang_18 branch from 297be31 to 3bf78f5 Compare September 11, 2024 18:50
@ispeters ispeters changed the base branch from enable_async_stacks_for_msvc to main September 11, 2024 18:50
@ispeters ispeters merged commit c271761 into main Sep 11, 2024
105 checks passed
@ispeters ispeters deleted the add_gcc_15_and_clang_18 branch September 11, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants