Replace nproc in macOS setup script #11186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@majetideepak FYI. |
✅ Deploy Preview for meta-velox canceled.
|
czentgr
force-pushed
the
cz_replace_macos_nproc
branch
from
fec7122 to
b3cc441
Compare
majetideepak
approved these changes
Oct 7, 2024
majetideepak
added
the
ready-to-merge
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nproc may not be found on macOS causing boost not to install. Instead, switch to use sysctl to determine the number of logical CPU that nproc would have returned.
czentgr
force-pushed
the
cz_replace_macos_nproc
branch
from
b3cc441 to
41c838d
Compare
kgpai
approved these changes
Oct 8, 2024
|
@xiaoxmeng merged this pull request in b63622d. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: nproc may not be found on macOS causing boost not to install. Instead, switch to use existing NPROC to determine the number of logical CPU that nproc would have returned. Pull Request resolved: facebookincubator#11186 Reviewed By: kgpai Differential Revision: D64000667 Pulled By: xiaoxmeng fbshipit-source-id: 8238f49785508b9aee10794db4eb15f1f3a167d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nproc may not be found on macOS causing boost not to install. Instead, switch to use existing NPROC to determine the number of logical CPU that nproc would have returned.