feat(fuzzer): Update "tryFlipJoinSides" functions to handle multi-joins #11938
+537
−406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
✅ Deploy Preview for meta-velox canceled.
|
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
53df0dc to
5538665
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
5538665 to
822456a
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
822456a to
e6f8727
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
e6f8727 to
4a54e29
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively the sides of all join nodes that are eligible to be flipped. Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
4f17be8 to
664154c
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
664154c to
1f79f97
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
1f79f97 to
af7238c
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
added 2 commits
January 10, 2025 14:10
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
DanielHunte
force-pushed
the
export-D67606686
branch
from
af7238c to
0b6241d
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
|
This pull request was exported from Phabricator. Differential Revision: D67606686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent.
Differential Revision: D67606686