Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double slash comments from css files #45

Merged

Conversation

david-wagih
Copy link

Why ?

to fix some errors in the css files inside the front end app

How ?

replace the double slashes before the comments with the /* */

Test plan

cd stopes/ui/seamlisten/react_app
npm run build

@facebook-github-bot
Copy link

Hi @david-wagih!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2023
@Celebio
Copy link
Member

Celebio commented Jul 3, 2023

This is for #43

Copy link
Member

@Celebio Celebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are also:
react_app/src/common/components/audio/PlayArea.css
react_app/src/common/components/audio/WaveSurfer.css
react_app/src/common/components/table/table.css
react_app/src/common/components/spinners/spinner.css

@david-wagih
Copy link
Author

@Celebio I fixed the remaining CSS files as you mentioned

@david-wagih david-wagih requested a review from Celebio July 3, 2023 11:56
Copy link
Member

@Celebio Celebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Celebio Celebio merged commit 7801629 into facebookresearch:seamlisten Jul 3, 2023
Mortimerp9 pushed a commit that referenced this pull request Jul 5, 2023
* remove double slash comments from css files

* remove double slash comments from the remaining four css files
Mortimerp9 pushed a commit that referenced this pull request Jul 5, 2023
* remove double slash comments from css files

* remove double slash comments from the remaining four css files
Mortimerp9 pushed a commit that referenced this pull request Jul 5, 2023
* remove double slash comments from css files

* remove double slash comments from the remaining four css files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants