-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove double slash comments from css files #45
remove double slash comments from css files #45
Conversation
Hi @david-wagih! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This is for #43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are also:
react_app/src/common/components/audio/PlayArea.css
react_app/src/common/components/audio/WaveSurfer.css
react_app/src/common/components/table/table.css
react_app/src/common/components/spinners/spinner.css
@Celebio I fixed the remaining CSS files as you mentioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* remove double slash comments from css files * remove double slash comments from the remaining four css files
* remove double slash comments from css files * remove double slash comments from the remaining four css files
* remove double slash comments from css files * remove double slash comments from the remaining four css files
Why ?
to fix some errors in the css files inside the front end app
How ?
replace the double slashes before the comments with the /* */
Test plan
cd stopes/ui/seamlisten/react_app
npm run build