Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adrian an me were talking about the lid, and what if the lid does not fully open. The system would not realize that and the starting shifter might not notice this in a webcam or so..
So we might take happily data with a half open lid.
I think, this is more or less okay, as long as we realize this at least during the next day ... and not after a week or month....
So we though, the overview video should maybe include something like the currents ... this would show a half open lid ...
And also ... I think, we get a nice handle on spotting hardware defects ... for just one minute of video ...
So I researched how to make screenshots of websites using javascript. And found a lot of ways involving hard to install stuff.
The easiest by far for me seemed
selenium
, which is pip installable. Together withPhantomJS
, which isapt-get
,homebrew
andnpm
installable, so I hope this can even run on Travis, in case we wanna go for testing.At the moment, this will fail with such an exception (in the logs)
resulting in the same black images, we get when the webcam page is down or so.
In case
phantomjs
was not installed e.g. like this: