Align dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 #404

TheCharlatan · 2022-02-21T20:17:00Z

The deps are alligned, but parallel swap test does not run yet.

As part of this PR and besides the pure API changes arising from the deps bump I also changed:

Peerd raw unencrypted connection to brontide encrypted connection
esb::SenderListto Endpoints
Renamed senders to the more appropriate endpoints
Use esb::Error<ServiceId> instead of esb::Error
Use lnp Ping, Error and Init messages instead of our own. This permanently binds us to the lnp::p2p crate

TheCharlatan · 2022-02-22T09:35:30Z

Needs merge of farcaster-project/farcaster-core#215

codecov-commenter · 2022-02-27T22:24:14Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 1.77778% with 221 lines in your changes missing coverage. Please review.

Project coverage is 13.0%. Comparing base (979fe9c) to head (0467b2b).
Report is 1632 commits behind head on main.

Files with missing lines	Patch %	Lines
src/swapd/runtime.rs	0.0%	101 Missing ⚠️
src/farcasterd/runtime.rs	0.0%	29 Missing ⚠️
src/walletd/runtime.rs	0.0%	27 Missing ⚠️
src/peerd/runtime.rs	0.0%	16 Missing ⚠️
src/service.rs	0.0%	13 Missing ⚠️
src/rpc/request.rs	0.0%	8 Missing ⚠️
src/syncerd/runtime.rs	0.0%	8 Missing ⚠️
src/peerd/opts.rs	0.0%	6 Missing ⚠️
src/error.rs	0.0%	2 Missing ⚠️
src/lib.rs	0.0%	2 Missing ⚠️
... and 7 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #404   +/-   ##
=====================================
  Coverage   13.0%   13.0%           
=====================================
  Files         27      27           
  Lines       7932    7915   -17     
=====================================
- Hits        1031    1030    -1     
+ Misses      6901    6885   -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lederstrumpf

tACK

TheCharlatan · 2022-04-25T10:58:19Z

Requires upstream patching in either internet2 or microservices. Tracking in LNP-WG/lnp-node#50

…785f7 Patches for dependency updates: Update clap usage Update LocalNode usage

originally specified by codegen tool, but induces a recursion limit overflow in bitcoin_scripts 0.7.0, so removing ("temporarily")

TheCharlatan · 2022-05-27T10:42:14Z

Seems like the CI decided to pass now, so I'll open it for review.

h4sh3d · 2022-05-27T10:51:43Z

Let me push 1 change so the monero functional tests pass with the newest monero-lws:latest. They currently don't because the container crash at startup because the name of a var changed.
After review and merge I can better test #444 and see if there is no real regression.

Lederstrumpf

tACK @ 0f38acb - thanks for having all your teeth pulled @TheCharlatan! ;)

Lederstrumpf · 2022-05-27T12:41:16Z

Cargo.toml

@@ -39,7 +39,9 @@ required-features = ["server"]

 [dependencies]
 # Farcaster crates
-farcaster_core = { version = "0.4.3", features = ["serde"] }
+# farcaster_core = { version = "0.4.4", features = ["serde"] }
+farcaster_core = { git = "https://github.com/farcaster-project/farcaster-core", branch = "main", features = ["serde"] }


I just did a release of core so that we don't have this wart anymore, but it failed since we currently have our own fork of secp256kfun in there. But I'm good to merge without this fixed.

I think we can't remove this easily, I'll see if we can upstream the change needed to release core. Agree that we should merge without it.

TheCharlatan · 2022-05-27T13:18:00Z

I can has merge?

TheCharlatan force-pushed the allignDeps branch 2 times, most recently from 4cbdcd8 to 888949d Compare February 21, 2022 23:05

Lederstrumpf mentioned this pull request Feb 27, 2022

dead connection not removed from active connections sometimes when creating another swap with a prior peer #397

Closed

Lederstrumpf force-pushed the allignDeps branch from c5bdd53 to 97431dc Compare February 27, 2022 22:20

TheCharlatan marked this pull request as ready for review February 27, 2022 22:26

Lederstrumpf approved these changes Feb 27, 2022

View reviewed changes

Lederstrumpf mentioned this pull request Apr 30, 2022

Revert dependency bump farcaster-project/farcaster-core#225

Merged

TheCharlatan force-pushed the allignDeps branch from 97431dc to 5e1a272 Compare May 23, 2022 11:06

TheCharlatan mentioned this pull request May 23, 2022

Reconnect peerd if connection is dropped during running swap #426

Merged

zkao marked this pull request as draft May 24, 2022 15:55

TheCharlatan changed the title ~~Allign dependencies with lnp-node a403e2561ff3f24056ed969f75c4f06f958…~~ Allign dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 May 25, 2022

TheCharlatan changed the title ~~Allign dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97~~ Align dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 May 25, 2022

TheCharlatan and others added 12 commits May 27, 2022 11:37

Allign dependencies with lnp-node a403e2561ff3f24056ed969f75c4f06f958…

c92187f

…785f7 Patches for dependency updates: Update clap usage Update LocalNode usage

Fix esb Error type

9737575

Resolve new endpoint type

d06cada

Resolve moved lnp-core deps

2a131ab

Fix error handling after dep allignment

268f466

Fix clap import after dep allignment

7442dfc

bump rust version in CI to 1.59.0

acba3de

bump farcaster_core to 0.4.4

dc006b6

Peerd: patch build after rebase

b9a85e8

Deps: Wrap up dependency bump

2607553

Peerd: Use brontide encryption for tcp session

9cf23ac

remove dead code linking from CI

a2afd40

originally specified by codegen tool, but induces a recursion limit overflow in bitcoin_scripts 0.7.0, so removing ("temporarily")

TheCharlatan force-pushed the allignDeps branch from f6060e7 to a2afd40 Compare May 27, 2022 09:41

Rebase fixup s/senders/endpoints/

1adcc78

TheCharlatan marked this pull request as ready for review May 27, 2022 10:42

TheCharlatan requested review from Lederstrumpf, zkao and h4sh3d May 27, 2022 10:42

h4sh3d added 2 commits May 27, 2022 13:35

fix: update monero lws env variable

0f38acb

fix: ran cargo msrv to find correct version

0467b2b

Lederstrumpf approved these changes May 27, 2022

View reviewed changes

h4sh3d mentioned this pull request May 27, 2022

GRPCD: A service daemon for a farcaster grpc api #443

Merged

h4sh3d approved these changes May 27, 2022

View reviewed changes

TheCharlatan merged commit 917fbc9 into farcaster-project:main May 27, 2022

h4sh3d mentioned this pull request May 27, 2022

Fix monero syncer address lws test #448

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 #404

Align dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 #404

TheCharlatan commented Feb 21, 2022 •

edited

Loading

TheCharlatan commented Feb 22, 2022

codecov-commenter commented Feb 27, 2022 •

edited

Loading

Lederstrumpf left a comment

TheCharlatan commented Apr 25, 2022

TheCharlatan commented May 27, 2022

h4sh3d commented May 27, 2022

Lederstrumpf left a comment

Lederstrumpf May 27, 2022

h4sh3d May 27, 2022 •

edited

Loading

TheCharlatan commented May 27, 2022

Align dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 #404

Align dependencies with lnp-node e81e693d1a92fc5aef10c423648db43e4b755e97 #404

Conversation

TheCharlatan commented Feb 21, 2022 • edited Loading

TheCharlatan commented Feb 22, 2022

codecov-commenter commented Feb 27, 2022 • edited Loading

Codecov Report

Lederstrumpf left a comment

Choose a reason for hiding this comment

TheCharlatan commented Apr 25, 2022

TheCharlatan commented May 27, 2022

h4sh3d commented May 27, 2022

Lederstrumpf left a comment

Choose a reason for hiding this comment

Lederstrumpf May 27, 2022

Choose a reason for hiding this comment

h4sh3d May 27, 2022 • edited Loading

Choose a reason for hiding this comment

TheCharlatan commented May 27, 2022

TheCharlatan commented Feb 21, 2022 •

edited

Loading

codecov-commenter commented Feb 27, 2022 •

edited

Loading

h4sh3d May 27, 2022 •

edited

Loading