CORE-991: only run express middleware on express routes #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianjkaplan
force-pushed
the
skip-middleware-option
branch
from
b073c6e to
7ad0965
Compare
ianjkaplan
force-pushed
the
skip-middleware-option
branch
from
7ad0965 to
8f0dc68
Compare
ianjkaplan
commented
Aug 18, 2024
| * only run middleware on routes that have not been registered with fastify | ||
| * middleware should be run as hooks with fastify routes for performance reasons | ||
| * and for compatibility with fastify.inject | ||
| */ | ||
| function runConnect (req, reply, next) { |
ianjkaplan
commented
Aug 18, 2024
|
|
||
| interface FastifyContextConfig { | ||
| /** | ||
| * @private |
There was a problem hiding this comment.
expressing that this type is a private type and one we probably shouldnt use in application code without good reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct