Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring
mkmf
has some unfortunate side-effects, like polluting the top-level namespace causing naming collisions with e.g.ffi
gem (see pbhogan/scrypt#47). In fact, it turns out that Ruby core recommends only requiringmkmf
inextconf.rb
, and not anywhere else (see https://bugs.ruby-lang.org/issues/12370#note-4).Therefore, this PR removes the
mkmf
dependency, and relies onOpen3.popenx
methods to be able to find the executables themselves via the system PATH. This also simplifies things a bit, removing the need for theelm_executable
variable.What do you think?