-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Milvus Vector Database Implementation #4751
Conversation
a714f85
to
458d434
Compare
c8a989f
to
c8f81a5
Compare
9f883cb
to
01c9a5f
Compare
@franciscojavierarceo as we add support for additional data store types, should we encourage devs to update the operator db store types accordingly as well? or should we treat that as a separate chore since the dev language is different?
feast/infra/feast-operator/api/v1alpha1/featurestore_types.go Lines 169 to 181 in 19424bc
looking at the python code, it appears we need to add several more supported types to the operator. |
83db9bc
to
a026729
Compare
Definitely. We can add an explicit test for it too and update the docs. I can do that in a separate PR after I get this thing wrangled. I'm still only partially through this and I still have quite a bit of work to do. |
e27258d
to
d05d601
Compare
e6a3f1f
to
218f58b
Compare
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
…ine retrieval. long term this can all go in the FeatureView class and in get_online_features Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
218f58b
to
bd5ff48
Compare
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
This PR introduces the Milvus Vector Database into Feast. This integration enhances the capability of Feast to handle and store vector embeddings, along with traditional features. More specifically, this allows for vector retrieval configurable at the feature-level.
.github/workflows/pr_local_integration_tests.yml
Makefile
docs/how-to-guides/customizing-feast/adding-support-for-a-new-online-store.md
sdk/python/docs/source/feast.infra.online_stores.milvus_online_store.rst
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
sdk/python/feast/repo_config.py
sdk/python/feast/type_map.py
_proto_value_to_value_type
functionsdk/python/tests/foo_provider.py
requested_features
as Optionalsdk/python/tests/integration/online_store/test_universal_online.py
Which issue(s) this PR fixes:
#4364
Misc
Will add docs in subsequent PR