fix: resolving syntax error while querying a feature view with column name starting with a number and BigQuery as data source #4908
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmisha
changed the title
|
@franciscojavierarceo Can you please let us know the next steps for this PR to be merged? |
|
Can you fix the DCO? You can do it manually in the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses a syntax error that occurs when querying a feature view with a column name starting with a number, specifically when using the BigQuery data source. To resolve this issue, the PR wraps all BigQuery feature view column names in backticks (`).
Which issue(s) this PR fixes:
Fixes #4688
Misc
This issue was closed by the PR #4713, however the bug was not resolved with 4713.
The current PR fixes bugs mentioned in #4688