feat: Adding EnvFrom support for the OptionalConfigs type to the Go Operator #4909
+889
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perator Signed-off-by: lrangine <[email protected]>
lokeshrangineni
changed the title
lokeshrangineni
changed the title
tchughesiv
requested changes
Jan 9, 2025
There was a problem hiding this comment.
@lokeshrangineni thanks for the contribution. please create a corresponding issue for this change and link to it in the description.
also, has this been tested in a kubernetes cluster to ensure the envFrom CR settings are being applied accordingly to the feature store deployment?
| @@ -461,6 +503,18 @@ var _ = Describe("FeatureStore Controller", func() { | |||
| Expect(resource.Status.Applied.Services.OnlineStore.Persistence.FilePersistence).NotTo(BeNil()) | |||
| Expect(resource.Status.Applied.Services.OnlineStore.Persistence.FilePersistence.Path).To(Equal(services.EphemeralPath + "/" + services.DefaultOnlineStorePath)) | |||
| Expect(resource.Status.Applied.Services.OnlineStore.Env).To(Equal(&[]corev1.EnvVar{{Name: testEnvVarName, Value: testEnvVarValue}, {Name: "fieldRefName", ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{APIVersion: "v1", FieldPath: "metadata.namespace"}}}})) | |||
| Expect(resource.Status.Applied.Services.OnlineStore.EnvFrom).To(Equal(&[]corev1.EnvFromSource{ | |||
There was a problem hiding this comment.
This is good, but we also need to be checking that the resulting Deployment object has a corresponding container w/ the appropriate envFrom settings present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding EnvFrom support for the OptionalConfigs type to the feast go operator
Fixes the Issue: 4916