-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add msig as enrich db option #62
base: devel
Are you sure you want to change the base?
Conversation
Hi @federicomarini , could you let me know when/if you have a chance to review the initial adjustments to the mentioned functions? |
Hi there @thomas-keller - sorry, I did not have time yet to dig through this in detail, been a busy week. |
Oh yeah, absolutely no rush @federicomarini . I was just circling back after making an example with the macrophage data. I have never really messed with CI before, so I don't really know how to debug/fix stuff for the different builds. I realized when making the example code below that I didn't roxygenise to update the exports/etc. However, I did run roxygenise on my test branch, but it didn't update anything except deprecated.Rd. If you have any advice or resources I can read up on, let me know. Helping out with libraries is pretty new to me. Anyway, here is the example code that runs on the test branch (on my windows machine): library(msigdbr) data("gse", package = "macrophage") m_df<- msigdbr::msigdbr(species='Homo sapiens',category='H') gse2<-gse gse2=gse2[!is.na(ge),] ge=ge[!duplicated(ens)] #gse2 has rownames as symbols to match pathway info #same vst data with ensembl ids instead for limma/limma2df pwys=split(as.character(m_df$gene_symbol), m_df$gs_name) #gsva setup and call #generic limma call lfit <- lmFit(gr1, mod) #pull out the Infg vs naive contrast (coefficient 7) #use limma for gene DE as example anno_dfm <- data.frame( #new functions not exported... res_de=GeneTonic:::limma2df(ttg) em=enhance_table(res_enrich,res_de,anno_dfm,chars_limit=40) ggs=ggs_graph(res_enrich,res_de,anno_dfm) ggs %>% |
Hi,
here is my initial idea for letting msig (or in principle other databases) be the database used in shake functions, and later downstream in ggs_graph, etc.
To avoid breaking changes, I've made the following changes
What are your thoughts? My focus was on the enhance_table and ggs_graph for my immediate research needs, but if other functions don't rely on goterm descriptions I think they will work as normal.
I'll work on an example limma/gsva prep on the macrophage data if this seems like a worthwhile addition.