add a top-level !user command with subcommands #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abompard
requested changes
Oct 12, 2023
fedora/fas.py
Outdated
| """ | ||
| await self._user_localtime(evt, username) | ||
|
|
||
| @command.passive("^!(hi|hello|hello2|hellomynameis|fasinfo|localtime)(?:\\s+|$)(.*)") |
There was a problem hiding this comment.
You can user the r"" trick here as well.
This replaces the old !user command (which displayed user info) with a new top level !user command with the following sub-commands (localtime, hello, info). Had to implement aliases for these 3 subcommands manually, as maubot wont let you alias a command-level to a command + subcommand. So these are done with a passive command. Signed-off-by: Ryan Lerch <[email protected]>
ryanlerch
force-pushed
the
top-level-user-command
branch
from
eb5856d to
4fdc89a
Compare
|
Okay, fixed:
other comments i have commented back with my thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the old !user command (which displayed user info) with a new top level !user command with the following sub-commands (localtime, hello, info).
Had to implement aliases for these 3 subcommands manually, as maubot wont let you alias a command-level to a command + subcommand. So these are done with a passive command.