-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] DNS hoster INWX #19
Conversation
* [ADD] DNS provider 'INWX' to argument_specs.yml * [ADD] INWX sanity checks * [ADD] INWX create * [ADD] INWX cleanup
INWX enforces a TTL of min. 300 seconds. I did not include this in the sanity checks - as there arent any for the other provider. |
ohhh. and i fu**** up... - name: Wait for DNS entries to propagate
community.dns.wait_for_txt:
always_ask_default_resolver: false will remove |
Remove `always_ask_default_resolver: false` from module `community.dns.wait_for_txt` while 'Wait for DNS entries to propagate'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you please add a changelog fragment (minor_changes
)?
You also need to update docs/docsite/rst/general_role_parameters.rst and docs/docsite/rst/acme_certificate_role.rst.
* [FIX] multiple record values dns-inwx-create.yml this is necessary as long as inwx/ansible-collection#9 is not resolved. * Update general_role_parameters.rst * Update acme_certificate_role.rst
QA is important. NOW it does what it should do. |
and learn how to keep GIT clean... Thanks for your understanding. |
`ERROR: docs/docsite/rst/general_role_parameters.rst:95:0: Bullet list ends without a blank line; unexpected unindent.` / `./docs/docsite/rst/general_role_parameters.rst:95:0: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.` I hope that is the needed fix.
@felixfontein
|
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides this, LGTM!
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
@Kariton thanks a lot for contributing this! I'll probably create a new release later this week or next weekend. |
Add INWX by utilizing inwx.collection
[ADD] DNS provider 'INWX' to argument_specs.yml
[ADD] INWX sanity checks
[ADD] INWX create
[ADD] INWX cleanup