Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] DNS hoster INWX #19

Merged
merged 17 commits into from
Oct 31, 2021
Merged

[ADD] DNS hoster INWX #19

merged 17 commits into from
Oct 31, 2021

Conversation

Kariton
Copy link
Contributor

@Kariton Kariton commented Oct 24, 2021

Add INWX by utilizing inwx.collection

  • [ADD] DNS provider 'INWX' to argument_specs.yml

  • [ADD] INWX sanity checks

  • [ADD] INWX create

  • [ADD] INWX cleanup

* [ADD] DNS provider 'INWX' to argument_specs.yml

* [ADD] INWX sanity checks

* [ADD] INWX create

* [ADD] INWX cleanup
@Kariton
Copy link
Contributor Author

Kariton commented Oct 24, 2021

INWX enforces a TTL of min. 300 seconds.
This is respected while creation - and waiting for propagation.

I did not include this in the sanity checks - as there arent any for the other provider.

@Kariton
Copy link
Contributor Author

Kariton commented Oct 24, 2021

ohhh. and i fu**** up...
my PR dns-inwx-create.yml includes:

- name: Wait for DNS entries to propagate
  community.dns.wait_for_txt:
    always_ask_default_resolver: false

will remove always_ask_default_resolver: false!

Remove `always_ask_default_resolver: false` from module `community.dns.wait_for_txt` while 'Wait for DNS entries to propagate'
Copy link
Owner

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment (minor_changes)?

You also need to update docs/docsite/rst/general_role_parameters.rst and docs/docsite/rst/acme_certificate_role.rst.

roles/acme_certificate/tasks/dns-inwx-create.yml Outdated Show resolved Hide resolved
* [FIX] multiple record values dns-inwx-create.yml
this is necessary as long as inwx/ansible-collection#9 is not resolved.

* Update general_role_parameters.rst

* Update acme_certificate_role.rst
@Kariton
Copy link
Contributor Author

Kariton commented Oct 28, 2021

QA is important. NOW it does what it should do.

@Kariton
Copy link
Contributor Author

Kariton commented Oct 28, 2021

and learn how to keep GIT clean...

Thanks for your understanding.
And a relay big thanks for your lovely role! :)

`ERROR: docs/docsite/rst/general_role_parameters.rst:95:0: Bullet list ends without a blank line; unexpected unindent.` /
`./docs/docsite/rst/general_role_parameters.rst:95:0: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.`

I hope that is the needed fix.
@Kariton
Copy link
Contributor Author

Kariton commented Oct 29, 2021

@felixfontein
How do I resolve this - can I see where the problem is?

Run yamllint .
  yamllint .
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.8.12/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.12/x64/lib
Error: [trailing-spaces] trailing spaces
Error: Process completed with exit code 1.

docs/docsite/rst/general_role_parameters.rst Outdated Show resolved Hide resolved
docs/docsite/rst/general_role_parameters.rst Outdated Show resolved Hide resolved
docs/docsite/rst/requirements.rst Outdated Show resolved Hide resolved
roles/acme_certificate/meta/argument_specs.yml Outdated Show resolved Hide resolved
roles/acme_certificate/tasks/dns-inwx-create.yml Outdated Show resolved Hide resolved
docs/docsite/rst/general_role_parameters.rst Outdated Show resolved Hide resolved
Copy link
Owner

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this, LGTM!

docs/docsite/rst/general_role_parameters.rst Outdated Show resolved Hide resolved
roles/acme_certificate/tasks/dns-inwx-create.yml Outdated Show resolved Hide resolved
changelogs/fragments/19-add-inwx-dns-provider.yaml Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 76a0493 into felixfontein:main Oct 31, 2021
@felixfontein
Copy link
Owner

@Kariton thanks a lot for contributing this!

I'll probably create a new release later this week or next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants