This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
Switch from global to DE endpoints #127
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for opening a PR! 🚀 🤓 I am wondering if we could just convert this into a configuration option and allow the user to tinker with this 🤔 |
|
Yeah to be honest I'm not really sure if there is rhyme or reason behind which to choose when. I just went off of that one commentor's suggestion and it appears to be working reliably ever since. |
|
I had the issue with "Too many login attempts" for months and since a few days the global endpoint is not reachable anymore. The DE endpoint works perfectly. Thanks for the fix! |
|
Tried this PR and it seems to work good, do you believe it can be merged? |
Closed
|
Sorry for the delay. |
|
See #130 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #125, this PR matches the behavior of the go implementation by only using the .de endpoints for authentication. This has been working reliably on my end to resolve the aforementioned issue, however it'd be great if others could test it out to make sure I'm not breaking anything elsewhere.