-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy errors #914
Fix mypy errors #914
Conversation
Codecov Report
@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 86.40% 86.56% +0.15%
==========================================
Files 91 91
Lines 5326 5448 +122
==========================================
+ Hits 4602 4716 +114
- Misses 724 732 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@jcreinhold, I know this is a huge PR, but could you please quickly skim through it and approve it if it looks good to you? |
Ok, I think I messed up and have made things not compatible with Python < 3.10. I'll have to turn this into a draft and work more on this PR. |
0ee3be8
to
c93d303
Compare
Fix some mypy errors Fix some mypy errors Fix some mypy errors Fix some flake8 errors Fix some mypy errors Fix some mypy errors Fix some mypy errors Fix tests Edit pre-commit config [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
Hey @fepegar I just started a new job and am pretty busy. I'll try to review the PR this weekend, but, if you don't hear from me by the end of this weekend (July 3), I might be too pressed for time to meaningfully review this. |
Related to #810.
Description
This pull request addresses many of the mypy errors in the library. Next should be:
--strict
flagChecklist
CONTRIBUTING
docs and have a developer setup (especially important arepre-commit
andpytest
)pytest
make html
inside thedocs/
folder