-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hanabi1224 upgrade deps #1770
Open
cryptonemo
wants to merge
7
commits into
master
Choose a base branch
from
hanabi1224-upgrade-deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hanabi1224 upgrade deps #1770
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b005a6a
chore(deps): upgrade a few dependencies
hanabi1224 b57d0b2
feat: upgrade rust-toolchain
cryptonemo 00b775c
fix: clippy updates required by toolchain update
cryptonemo e266b9c
fix: rename test
cryptonemo 6e53c05
fix: additional clippy updates
cryptonemo a616f90
fix: update rust-toolchain
cryptonemo f662f9b
fix: apply review feedback
cryptonemo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -563,15 +563,14 @@ need to handle the potential bit-level misalignments: | |||||
// offset and num_bytes are based on the unpadded data, so | ||||||
// if [0, 1, ..., 255] was the original unpadded data, offset 3 and len 4 would return | ||||||
// [3, 4, 5, 6]. | ||||||
#[allow(clippy::multiple_bound_locations)] | ||||||
pub fn write_unpadded<W: ?Sized>( | ||||||
pub fn write_unpadded<W>( | ||||||
source: &[u8], | ||||||
target: &mut W, | ||||||
offset: usize, | ||||||
len: usize, | ||||||
) -> io::Result<usize> | ||||||
where | ||||||
W: Write, | ||||||
W: Write + Sized, | ||||||
{ | ||||||
// Check that there's actually `len` raw data bytes encoded inside | ||||||
// `source` starting at `offset`. | ||||||
|
@@ -631,16 +630,15 @@ The reader will generally operate with bit precision, even if the padded | |||||
layout is byte-aligned (no extra bits) the data inside it isn't (since | ||||||
we pad at the bit-level). | ||||||
**/ | ||||||
#[allow(clippy::multiple_bound_locations)] | ||||||
fn write_unpadded_aux<W: ?Sized>( | ||||||
fn write_unpadded_aux<W>( | ||||||
padding_map: &PaddingMap, | ||||||
source: &[u8], | ||||||
target: &mut W, | ||||||
write_pos: usize, | ||||||
max_write_size: usize, | ||||||
) -> io::Result<usize> | ||||||
where | ||||||
W: Write, | ||||||
W: Write + Sized, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{ | ||||||
// Position of the reader in the padded bit stream layout, deduced from | ||||||
// the position of the writer (`write_pos`) in the raw data layout. | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.