[Testing only] - Load icons from FTP only for hidden and shortcut files #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gave92
changed the title
|
Thanks @xpoppyx closing for now as more work is necessary. Plus it seems this makes the icons "flash" when changing layout mode? |
|
They do load again at a higher resolution. Not sure why you don't notice that with the current method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Fixes #3163
@xpoppyx since you can "easily" reproduce the issue (comment in #4199), I'm curious if you could test this PR and see if the issue is fixed.
[The effect of the issue is: after opening different folders, eventually the shortcuts and the extra options of the contextual menu are no longer shown]
Note: this is based on main so maybe you have to turn off file caching in order to repro the issue.
Details of Changes
Only use FTP for loading hidden and shortcut files icons.
Validation
How did you test these changes?