Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Removal of IStorageItemWithPath #4825

Closed
wants to merge 2 commits into from

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented May 3, 2021

Details of Changes
This PR intends to remove all usages of IStorageItemWithPath.

Currently it compiles but I haven't test whether it works or not due to the .NET 6 SDK on my machine broke the wrapproj (so I cannot build the package). I believe there's still plenty of work need to be done to make all things right, and I also need to rebase my branch, but at least it gives an initial blueprint about how things will change after the removal of IStorageItemWithPath.

Contributes to #4180.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft May 3, 2021 15:07
@d2dyno1
Copy link
Member

d2dyno1 commented Jun 2, 2021

How's progress on this? :)

@hez2010
Copy link
Member Author

hez2010 commented Jun 3, 2021

@d2dyno1 Sorry for the delay. I'm a bit busy recently, will be able to continue working on this after mid-July.

@hez2010 hez2010 force-pushed the feature/IStorageItem branch from 3510905 to e329de0 Compare July 8, 2021 12:29
@hez2010 hez2010 force-pushed the feature/IStorageItem branch from e329de0 to 4910366 Compare July 21, 2021 09:28
@hez2010 hez2010 force-pushed the feature/IStorageItem branch from 4910366 to 239c3d7 Compare July 22, 2021 14:10
@hez2010
Copy link
Member Author

hez2010 commented Aug 5, 2021

Postponed.

@hez2010 hez2010 closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants