Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #3

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Upgrade dependencies #3

merged 1 commit into from
Dec 24, 2023

Conversation

yabirgb
Copy link
Contributor

@yabirgb yabirgb commented Dec 20, 2023

Hello! I'm yabir from the @rotki team and I work with @LefterisJP. Recently there was a release and it broke our app as we were running a fork of this project. What I've done here is:

  • update the dependencies
  • replace the setup.py with pyproject.toml
  • adjusted types in the functions

The only issue is that I had to make a PR to add support for keccak at hashberg-io/multiformats#16 and it hasn't release yet.

Feel free to review and once it releases my patch we can update the dep in the pyproject

@sg495
Copy link

sg495 commented Dec 20, 2023

Hi everybody, and apologies for the temporary drop in keccak support. Following @yabirgb's pull request, we have now released multiformats>=0.3.1.post4, with keccak support restored (now based on pycryptodomex).

@yabirgb
Copy link
Contributor Author

yabirgb commented Dec 23, 2023

@filips123 feel free to check when you can

@yabirgb yabirgb force-pushed the upgrade-deps branch 2 times, most recently from e31fbb3 to d34b399 Compare December 23, 2023 08:43
Upgrade dependencies and replace setup.py by pyproject
@filips123
Copy link
Owner

Does this PR replace #2?

@yabirgb
Copy link
Contributor Author

yabirgb commented Dec 24, 2023

Yes @filips123 ! It finishes what was started in #2

Copy link
Owner

@filips123 filips123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems fine. I will probably make a few other changes and then release it soon.

@filips123 filips123 merged commit 90c3085 into filips123:master Dec 24, 2023
11 checks passed
@filips123 filips123 linked an issue Dec 24, 2023 that may be closed by this pull request
@yabirgb yabirgb deleted the upgrade-deps branch December 24, 2023 15:34
yabirgb added a commit to yabirgb/rotki that referenced this pull request Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multimarts here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
yabirgb added a commit to yabirgb/rotki that referenced this pull request Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multiformats here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
LefterisJP pushed a commit to rotki/rotki that referenced this pull request Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multiformats here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
OjusWiZard pushed a commit to OjusWiZard/rotki that referenced this pull request Dec 26, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multiformats here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All dependencies are archived and deprecated. Let's upgrade
3 participants