WIP - enable data cube deployment #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8dff903 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3741 +/- ##
==========================================
- Coverage 44.97% 44.90% -0.07%
==========================================
Files 2218 2218
Lines 384646 384646
Branches 16415 15861 -554
==========================================
- Hits 172998 172732 -266
- Misses 210632 211127 +495
+ Partials 1016 787 -229
|
akphi
reviewed
Dec 17, 2024
packages/legend-application-data-cube-deployment/data-cube.config.js
Outdated
Show resolved
Hide resolved
| "engine": { | ||
| "url": "${PROTOCOL}://${ENGINE_HOST}:${ENGINE_PORT}/api" | ||
| }, | ||
| "depot": { |
There was a problem hiding this comment.
probably don't need depot for now
packages/legend-application-data-cube-deployment/docker/config.json
Outdated
Show resolved
Hide resolved
akphi
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
enable data cube deployment
How did you test this change?