Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataCube dark mode #3785

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

travisstebbins
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented Jan 3, 2025

⚠️ No Changeset found

Latest commit: 015e5ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 22.75449% with 258 lines in your changes missing coverage. Please review.

Project coverage is 44.59%. Comparing base (4ce8513) to head (015e5ca).

Files with missing lines Patch % Lines
...ata-cube/src/components/view/grid/DataCubeGrid.tsx 0.00% 85 Missing ⚠️
...ew/editor/DataCubeEditorGeneralPropertiesPanel.tsx 0.00% 77 Missing ⚠️
.../view/editor/DataCubeEditorMutableConfiguration.ts 0.00% 73 Missing ⚠️
...nents/view/editor/DataCubeEditorColumnSelector.tsx 0.00% 8 Missing ⚠️
.../view/editor/DataCubeEditorVerticalPivotsPanel.tsx 0.00% 5 Missing ⚠️
...ponents/view/editor/DataCubeEditorColumnsPanel.tsx 0.00% 2 Missing ⚠️
...iew/editor/DataCubeEditorHorizontalPivotsPanel.tsx 0.00% 2 Missing ⚠️
...omponents/view/editor/DataCubeEditorSortsPanel.tsx 0.00% 2 Missing ⚠️
...e/src/stores/view/grid/DataCubeGridClientEngine.ts 0.00% 2 Missing ⚠️
...res/view/grid/DataCubeGridConfigurationBuilder.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
+ Coverage   44.53%   44.59%   +0.05%     
==========================================
  Files        2236     2236              
  Lines      388816   389047     +231     
  Branches    16349    15953     -396     
==========================================
+ Hits       173174   173498     +324     
- Misses     214581   214763     +182     
+ Partials     1061      786     -275     
Files with missing lines Coverage Δ
...d-data-cube/src/stores/core/DataCubeQueryEngine.ts 90.83% <100.00%> (+0.53%) ⬆️
...be/src/stores/core/models/DataCubeConfiguration.ts 97.42% <100.00%> (+0.27%) ⬆️
...ponents/view/editor/DataCubeEditorColumnsPanel.tsx 0.00% <0.00%> (ø)
...iew/editor/DataCubeEditorHorizontalPivotsPanel.tsx 0.00% <0.00%> (ø)
...omponents/view/editor/DataCubeEditorSortsPanel.tsx 0.00% <0.00%> (ø)
...e/src/stores/view/grid/DataCubeGridClientEngine.ts 0.00% <0.00%> (ø)
...res/view/grid/DataCubeGridConfigurationBuilder.tsx 0.00% <0.00%> (ø)
.../view/editor/DataCubeEditorVerticalPivotsPanel.tsx 0.00% <0.00%> (ø)
...nents/view/editor/DataCubeEditorColumnSelector.tsx 0.00% <0.00%> (ø)
.../view/editor/DataCubeEditorMutableConfiguration.ts 0.00% <0.00%> (ø)
... and 2 more

... and 363 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant